Skip to content

added http code param to WebServer.streamFile (#6899) #6995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 26, 2022

Conversation

r-downing
Copy link
Contributor

Description of Change

Add optional http code param to WebServer.streamFile() - backwards compatible

Related links

Closes #6899

@SuGlider
Copy link
Collaborator

Thanks for the contribution @r-downing!

Please check some compiling CI errors in order to move forward:
https://github.com/espressif/arduino-esp32/runs/7377749653?check_suite_focus=true
https://github.com/espressif/arduino-esp32/runs/7377750105?check_suite_focus=true

@r-downing r-downing force-pushed the streamFile-responseCode branch from 4844372 to fb038ba Compare July 17, 2022 14:15
@r-downing r-downing force-pushed the streamFile-responseCode branch from 3d6641c to 90bb748 Compare July 17, 2022 14:35
@SuGlider SuGlider requested review from SuGlider and PilnyTomas July 20, 2022 13:38
@SuGlider SuGlider self-assigned this Jul 20, 2022
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @r-downing!

@SuGlider SuGlider merged commit fef932c into espressif:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

streamFile with custom HTTP code
2 participants